Keep track of remote xlog and basebackup #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix some tests
determine_backups_to_delete() should not modify self.remote_basebackup
Use remote_basebackup because it is the same value as the state. We also need to copy the array because the array remains the same object. Previous code replace the array with a new one ?
Simply deletion of remote wal segment
Vampouille
added a commit
to camptocamp/pghoard
that referenced
this pull request
Oct 2, 2019
port of * a8977b0 * 3bebb3e from Aiven-Open#367
|
@Ormod Can you take a look at this merge request ? As discussed in #366, I want to keep track of remote files uploaded. So I added some attributes to store remote files and expose metrics:
|
Vampouille
added a commit
to camptocamp/pghoard
that referenced
this pull request
Mar 11, 2020
port of * a8977b0 * 3bebb3e from Aiven-Open#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to keep tracks of remote files uploaded. As mentioned in #366, with a list of xlog on remote storage, we can compute several new metrics and check if there is gap in the xlog sequence. This PR is a based for another PR that will add new metrics as described in #366.
This PR mainly adds 2 attributes on PGHoard class:
remote_xlogremote_basebackupand code to keep those attributes up to date:
handle_site()will fetch xlogs and basebackups from remote storage and populatesremote_xlogandremote_basebackupattributes.remote_xlogandremote_basebackupattributes.remote_xlogorremote_basebackupattributes will be updated.Additionally, this PR merge
remote_basebackupattribute withstate["backup_sites"][site]["basebackups"]: